Barcode generator: rfct, ux improvements, implement EAN-8.#154
Merged
xMasterX merged 2 commits intoDarkFlippers:devfrom Nov 10, 2022
Merged
Barcode generator: rfct, ux improvements, implement EAN-8.#154xMasterX merged 2 commits intoDarkFlippers:devfrom
xMasterX merged 2 commits intoDarkFlippers:devfrom
Conversation
xMasterX
approved these changes
Nov 10, 2022
Member
xMasterX
left a comment
xMasterX
left a comment
There was a problem hiding this comment.
All tested fine, thanks for PR, thats a good improvement for this plugin
Contributor
|
Could you add EAN-13 type barcode gen? It's the most used for everything |
|
Hi, just to feedback that Code-128 doesn't seems to work as it says 'Missing Encoding Table' |
Member
Wrong repo, there is no code 128 in this PR or in this whole repo |
Apologies my bad. yea, no Code-128 after a fresh update. was trying to save some of the cards to test on them. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Verification
Checklist (For Reviewer)